[ 
https://issues.apache.org/jira/browse/NIFI-3454?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15860315#comment-15860315
 ] 

Otto Fowler commented on NIFI-3454:
-----------------------------------

Apache Maven 3.3.9 (bb52d8502b132ec0a5a3f4c09453c07478323dc5; 
2015-11-10T11:41:47-05:00)
Maven home: /usr/local/Cellar/maven/3.3.9/libexec
Java version: 1.8.0_31, vendor: Oracle Corporation
Java home: /Library/Java/JavaVirtualMachines/jdk1.8.0_31.jdk/Contents/Home/jre
Default locale: en_US, platform encoding: UTF-8
OS name: "mac os x", version: "10.12.3", arch: "x86_64", family: "mac"

> Tests in TestClassloaderUtils should consistently use the FileNameFilter when 
> using directories
> -----------------------------------------------------------------------------------------------
>
>                 Key: NIFI-3454
>                 URL: https://issues.apache.org/jira/browse/NIFI-3454
>             Project: Apache NiFi
>          Issue Type: Bug
>          Components: Tools and Build
>    Affects Versions: 1.1.1
>         Environment: Mac OS X ( any version )  Java 1.8.0_31  Maven 3.3.9
>            Reporter: Otto Fowler
>
> DS_Store files [https://en.wikipedia.org/wiki/.DS_Store]  may be present in 
> any directory on Mac OS X. 
> Any call made to getURLsForClasspath  or getCustomClassLoader passing 
> directories an not paths to jars for modules will return these files as urls 
> unless they are specifically filtered out using the FileNameFilter parameter.
> The FileNameFilter parameter to these functions can be used to protect 
> against this, and be sure the URL's returned are for the expected items.  In 
> fact there is a function  getJarFilenameFilter in the TestClassloaderUtils 
> already, that is used by the getCustomClassloader tests.
> This function should be used in all of the tests that pass in directories and 
> not paths that are to jar files.  Without it, NiFi builds that enable tests 
> will fail on Mac OS X if .DS_Store files exist in the testing directory.
> This problem also effects TestIdentifyMimeType.java, where it is doing a 
> directory listing, and should ignore "." files.
>         



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to