[
https://issues.apache.org/jira/browse/NIFI-3449?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15860786#comment-15860786
]
ASF GitHub Bot commented on NIFI-3449:
--------------------------------------
Github user jvwing commented on a diff in the pull request:
https://github.com/apache/nifi/pull/1482#discussion_r100472194
--- Diff:
nifi-nar-bundles/nifi-gcp-bundle/nifi-gcp-processors/src/main/java/org/apache/nifi/processors/gcp/storage/StorageAttributes.java
---
@@ -0,0 +1,98 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.nifi.processors.gcp.storage;
+
+
+/**
+ * Common attributes being written and accessed through Google Cloud
Storage.
+ */
+public class StorageAttributes {
+ private StorageAttributes() {}
+
+ public static final String BUCKET_ATTR = "gcs.bucket";
+ public static final String BUCKET_DESC = "Bucket of the object.";
+
+ public static final String KEY_ATTR = "gcs.key";
+ public static final String KEY_DESC = "Name of the object.";
+
+ public static final String SIZE_ATTR = "gcs.size";
+ public static final String SIZE_DESC = "Size of the object.";
+
+ public static final String CACHE_CONTROL_ATTR = "gcs.cache.control";
+ public static final String CACHE_CONTROL_DESC = "Data cache control of
the object.";
+
+ public static final String COMPONENT_COUNT_ATTR =
"gcs.component.count";
+ public static final String COMPONENT_COUNT_DESC = "The number of
components which make up the object.";
+
+ public static final String CONTENT_DISPOSITION_ATTR =
"gcs.content.disposition";
+ public static final String CONTENT_DISPOSITION_DESC = "The data
content disposition of the object.";
+
+ public static final String CONTENT_ENCODING_ATTR =
"gcs.content.encoding";
+ public static final String CONTENT_ENCODING_DESC = "The content
encoding of the object.";
+
+ public static final String CONTENT_LANGUAGE_ATTR =
"gcs.content.language";
+ public static final String CONTENT_LANGUAGE_DESC = "The content
language of the object.";
+
+ public static final String CONTENT_TYPE_ATTR = "gcs.content.type";
--- End diff --
Did you consider using `mime.type` here? It is a mostly-standardized NiFi
attribute for content types, widely used by other processors. See
[CoreAttributes](https://github.com/apache/nifi/blob/master/nifi-commons/nifi-utils/src/main/java/org/apache/nifi/flowfile/attributes/CoreAttributes.java).
> Create Google Cloud Platform/Google Cloud Storage Processors
> ------------------------------------------------------------
>
> Key: NIFI-3449
> URL: https://issues.apache.org/jira/browse/NIFI-3449
> Project: Apache NiFi
> Issue Type: New Feature
> Components: Extensions
> Reporter: Gene Peters
> Labels: features
>
> Hi all,
> We had a need in our production deployments to interact with Google Cloud
> Storage. At the time, NIFI-2809 hadn't seen much movement, and after applying
> the patch I found that the configuration was too specific for my needs (it's
> hardcoded to use "Application Default" credentials, everything uploaded to
> GCS is uploaded with the "public" ACL, etc). So I created a series of
> Processors / Controller Services based off of the AWS NiFi library, and would
> like to contribute them.
> Features:
> * All credentialing is handled by a controller service, allowing multiple
> processors to use the same service / credentials
> * An Abstract processor is provided which forms the basis for all GCP related
> processors.
> * The standard Google Cloud Storage operations are supported, very similarly
> to the AWS S3 processors: ListGCSBucket, DeleteGCSObject, FetchGCSObject,
> PutGCSObject
> * Everything is documented and unit tested.
> * I've also provided integration tests, but they're disabled by default (as
> they require Google Cloud credentials). To run them, use the flag
> {{skipGCPIntegrationTests=false}}
> Todo:
> * The GCP Java library's ReadChannel objects implement the "restorable"
> interface, which allows for state saving / checkpointing. I'd really like to
> leverage this with the State support that NiFi provides, but it would require
> serializing / deserializing the object.
> I'm going to be submitting this as a pull request through GitHub.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
