Copilot commented on code in PR #2063:
URL: https://github.com/apache/nifi-minifi-cpp/pull/2063#discussion_r2518224764
##########
core-framework/include/core/VariableRegistry.h:
##########
@@ -40,53 +44,37 @@ class VariableRegistryImpl : public virtual
VariableRegistry {
~VariableRegistryImpl() override = default;
- bool getConfigurationProperty(const std::string &property, std::string
&value) const override {
- auto prop = variable_registry_.find(property);
- if (prop != variable_registry_.end()) {
- value = prop->second;
- return true;
+ [[nodiscard]] std::optional<std::string> getConfigurationProperty(const
std::string_view key) const override {
Review Comment:
The override implementation accepts `const std::string_view key` but the
base interface declares the parameter without a name. For consistency and
clarity, consider adding a parameter name to the base interface declaration in
`minifi-api/include/minifi-cpp/core/VariableRegistry.h` line 34, such as
`getConfigurationProperty(std::string_view key)`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
