rfellows commented on code in PR #10523: URL: https://github.com/apache/nifi/pull/10523#discussion_r2523661477
########## nifi-frontend/src/main/frontend/apps/nifi/src/app/ui/common/component-state/component-state.component.scss: ########## Review Comment: * the effective hover color of the rows doesn't match the other tables. the summary tables, for instance, this is the applied style: https://github.com/apache/nifi/blob/main/nifi-frontend/src/main/frontend/libs/shared/src/assets/styles/_listing-table.scss#L93-L102 * when not in clustered mode, the sizing/placement of the columns isn't good: <img width="996" height="340" alt="Screenshot 2025-11-13 at 09 25 32" src="https://github.com/user-attachments/assets/fc038bdd-af16-4561-992c-3a45cdf24559"; /> * inconsistent column placement between a running and non running processor: <img width="992" height="260" alt="Screenshot 2025-11-13 at 09 53 10" src="https://github.com/user-attachments/assets/71decc60-fd15-4d9c-a96e-bcf7ed836b53"; /> * Dark mode isn't accounted for fully. the lines separating the rows are too strong in particular. <img width="1040" height="659" alt="Screenshot 2025-11-13 at 09 24 15" src="https://github.com/user-attachments/assets/58215ef6-b4dd-40bb-995d-81affe26b9c2"; /> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
