GitHub user ottobackwards opened a pull request:
https://github.com/apache/nifi/pull/1497
NIFI-3454 Tests should consistently use the FileNameFilter when reading
file names from directories
Tests that work with getting files from directories ( either doing listings
or building URLs for the classloader ) should use the FileNameFilter to ensure
unwanted files don't fowl the tests.
As an example, on Mac OS .DS_Store files will break some tests if present
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ x] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [ x] Does your PR title start with NIFI-XXXX where XXXX is the JIRA
number you are trying to resolve? Pay particular attention to the hyphen "-"
character.
- [x ] Has your PR been rebased against the latest commit within the target
branch (typically master)?
- [x ] Is your initial contribution a single, squashed commit?
### For code changes:
- [ x] Have you ensured that the full suite of tests is executed via mvn
-Pcontrib-check clean install at the root nifi folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file, including the main
LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main
NOTICE file found under nifi-assembly?
- [ ] If adding new Properties, have you added .displayName in addition to
.name (programmatic access) for each of the new properties?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in
which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build
issues and submit an update to your PR as soon as possible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ottobackwards/nifi NIFI-3454
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/1497.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1497
----
commit 238c59172106b68585d09251cc244694ab567fb7
Author: Otto Fowler <[email protected]>
Date: 2017-02-09T22:12:35Z
use the FileNameFilter when not passing down explit jar paths
Filter out ^. files when reading lists of files from directories
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
