kevdoran commented on code in PR #10530:
URL: https://github.com/apache/nifi/pull/10530#discussion_r2530036579
##########
nifi-extension-bundles/nifi-snmp-bundle/nifi-snmp-processors/src/main/java/org/apache/nifi/snmp/processors/ListenTrapSNMP.java:
##########
@@ -70,13 +76,14 @@
@WritesAttribute(attribute = SNMPUtils.SNMP_PROP_PREFIX + "*", description =
"Attributes retrieved from the SNMP response. It may include:"
+ " snmp$errorIndex, snmp$errorStatus, snmp$errorStatusText,
snmp$nonRepeaters, snmp$requestID, snmp$type, snmp$variableBindings")
@RequiresInstanceClassLoading
-public class ListenTrapSNMP extends AbstractSessionFactoryProcessor implements
VerifiableProcessor {
+public class ListenTrapSNMP extends AbstractSessionFactoryProcessor implements
VerifiableProcessor, ListenComponent {
public static final PropertyDescriptor SNMP_MANAGER_PORT = new
PropertyDescriptor.Builder()
.name("SNMP Manager Port")
.description("The port where the SNMP Manager listens to the
incoming traps.")
.required(true)
.addValidator(StandardValidators.PORT_VALIDATOR)
+ .identifiesListenPort(TransportProtocol.UDP, "snmptrap")
Review Comment:
I could be wrong, but I believe they are different protocols:
https://www.iana.org/assignments/service-names-port-numbers/service-names-port-numbers.xhtml?search=snmp
`snmp` is for the management server polling devices, and `snmptrap` is for
devices pushing to the management server. Given this is a listen processor and
the name of the processor, I assumed this is using the `snmptrap` protocol.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
