esecules commented on code in PR #10501:
URL: https://github.com/apache/nifi/pull/10501#discussion_r2542628209


##########
nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/src/main/java/org/apache/nifi/prometheusutil/PrometheusMetricsUtil.java:
##########
@@ -48,7 +49,7 @@ public class PrometheusMetricsUtil {
     private static final double NANOS_PER_MILLI = 1000000.0;
 
     public static CollectorRegistry createNifiMetrics(NiFiMetricsRegistry 
nifiMetricsRegistry, ProcessGroupStatus status,
-                                                      String instId, String 
parentProcessGroupId, String compType, String metricsStrategy) {
+                                                      String instId, String 
parentProcessGroupId, String compType, FlowMetricsReportingStrategy 
metricsStrategy) {

Review Comment:
   Fixed equality checks and simplified/consolidated the definitions for the 
two reporting strategies.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to