[
https://issues.apache.org/jira/browse/NIFI-15242?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18039952#comment-18039952
]
David Handermann commented on NIFI-15242:
-----------------------------------------
No problem, thanks for taking a closer look, I'm revisiting now as well.
The other properties like vault.read.timeout and vault.connection.timeout map
to references in the HashiCorpVaultConfiguration class. On closer inspection,
it looks like the property renaming can be kept, but the getProperty method in
the DirectPropertySource needs to be updated to translate those property
requests.
> Remove redundant name and display name in the VAULT_URI property descriptor
> found in HashiCorpVaultClientService
> ----------------------------------------------------------------------------------------------------------------
>
> Key: NIFI-15242
> URL: https://issues.apache.org/jira/browse/NIFI-15242
> Project: Apache NiFi
> Issue Type: Bug
> Reporter: Daniel Stieglitz
> Assignee: Daniel Stieglitz
> Priority: Minor
> Fix For: 2.7.0
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> Currently the property descriptor has
> {code:java}
> PropertyDescriptor VAULT_URI = new PropertyDescriptor.Builder()
> .name("Vault URI")
> .name("vault.uri")
> .displayName("Vault URI"){code}
> and it should look like
> {code:java}
> PropertyDescriptor VAULT_URI = new PropertyDescriptor.Builder()
> .name("vault.uri")
> .displayName("Vault URI"){code}
> in addition this line in the migrateProperties method should be removed as it
> is unnecessary (since its redundant):
> {code:java}
> config.renameProperty("vault.uri", VAULT_URI.getName());{code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
