joewitt commented on PR #10553: URL: https://github.com/apache/nifi/pull/10553#issuecomment-3568789092
Ah yeah sorry I was reacting to the idea of bringing encrypted provenance back instead of what this PR actually does/is. To the spirit of this PR itself it looks like what it aims to do is expand from package private to protected for many methods/fields of a couple provenance related classes. This would presumably allow someone else to write a provenance implementation in another package. For instance someone could write their own extension of this provenance extension in their own package which does say encrypted repos. Others being able to build their own thing is good! However, if my understanding is correct what I don't think is good about this is we create an API contractual obligation we're not seeking. We don't want to be restricted in changing how our provenance stuff works. It isn't meant for someone else to extend and modify. Why can't one simply copy our code and build their own solution? That creates no additional burden/obligation for us to maintain nor restricts our ability to change anything but does let those who wish to create their own provenance impl to do so. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
