dan-s1 commented on code in PR #10540:
URL: https://github.com/apache/nifi/pull/10540#discussion_r2556568476
##########
nifi-extension-bundles/nifi-poi-bundle/nifi-poi-services/src/main/java/org/apache/nifi/processors/excel/SplitExcel.java:
##########
@@ -229,7 +217,56 @@ public void onTrigger(ProcessContext context,
ProcessSession session) throws Pro
session.transfer(flowFileSplits, REL_SPLIT);
}
- private int copyRows(final Sheet originalSheet, final SXSSFSheet
destinationSheet) {
+ private CellCopyPolicy createCellCopyPolicy(InputFileType inputFileType) {
Review Comment:
Yes. I didn't think of that. That is certainly a better solution than to
having to create a new `CellCopyPolicy` for each for flow file.
##########
nifi-extension-bundles/nifi-poi-bundle/nifi-poi-services/src/main/java/org/apache/nifi/processors/excel/SplitExcel.java:
##########
@@ -229,7 +217,56 @@ public void onTrigger(ProcessContext context,
ProcessSession session) throws Pro
session.transfer(flowFileSplits, REL_SPLIT);
}
- private int copyRows(final Sheet originalSheet, final SXSSFSheet
destinationSheet) {
+ private CellCopyPolicy createCellCopyPolicy(InputFileType inputFileType) {
Review Comment:
Yes. I didn't think of that. That is certainly a better solution than to
having to create a new `CellCopyPolicy` for each flow file.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
