pvillard31 commented on code in PR #10562:
URL: https://github.com/apache/nifi/pull/10562#discussion_r2560508097
##########
nifi-frontend/src/main/frontend/apps/nifi/src/app/pages/settings/ui/registry-clients/registry-clients.component.spec.ts:
##########
@@ -228,10 +229,37 @@ describe('RegistryClients', () => {
uri: mockRegistryClientEntity.uri,
fromTimestamp: '2023-10-08T12:00:00.000Z',
componentId: mockRegistryClientEntity.id,
- componentType: ComponentType.FlowRegistryClient
+ componentType: ComponentType.FlowRegistryClient
+ }
+ })
+ );
+ });
+
+ it('should dispatch navigateToComponentDocumentation action when
viewRegistryClientDocumentation is called', async () => {
+ const { component, store } = await setup();
+ const mockRegistryClientEntity = createMockRegistryClientEntity();
+ jest.spyOn(store, 'dispatch');
+
+ component.viewRegistryClientDocumentation(mockRegistryClientEntity);
+
+ expect(store.dispatch).toHaveBeenCalledWith(
+ navigateToComponentDocumentation({
+ request: {
+ backNavigation: {
+ route: ['/settings', 'registry-clients',
mockRegistryClientEntity.id],
+ routeBoundary: ['/documentation'],
+ context: 'Registry Client'
+ },
+ parameters: {
+ componentType: ComponentType.FlowRegistryClient,
+ type: mockRegistryClientEntity.component.type,
+ group: mockRegistryClientEntity.component.bundle.group,
+ artifact:
mockRegistryClientEntity.component.bundle.artifact,
+ version:
mockRegistryClientEntity.component.bundle.version
}
- })
- );
- });
+ }
+ })
+ );
});
});
+});
Review Comment:
It was just formatting, not looking the same as in my IDE, thanks for this
command, should be much better now!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
