[ 
https://issues.apache.org/jira/browse/NIFI-15261?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Daniel Stieglitz updated NIFI-15261:
------------------------------------
    Description: 
Currently throughout the Apache NIFI code base there are property descriptors 
which represent URL/URI but do not use URL/URI validation. The likely reason 
for this is because the properties also support Expression Language expressions 
with flow file attributes. But in truth they could still use either 
org.apache.nifi.processor.util.URLValidator,  
org.apache.nifi.processor.util.StandardValidators.URI_VALIDATOR or 
org.apache.nifi.processor.util.StandardValidators.URI_LIST_VALIDATOR as they 
all support skipping over Expression Language expressions. 

Some examples are detailed in the table below
||Class||Property||
|RestLookupService|URL|
|BitbucketFlowRegistryClient|BITBUCKET_API_URL|
|AzureKeyVaultSecretsParameterProvider|KEY_VAULT_URI|
|DeleteSQS|QUEUE_URL|
|GetSQS|QUEUE_URL|
|PutSQS|QUEUE_URL|
|AbstractAzureLogAnalyticsReportingTask|LOG_ANALYTICS_URL_ENDPOINT_FORMAT|
|AzureLogAnalyticsProvenanceReportingTask|INSTANCE_URL|
|Neo4JCypherClientService|CONNECTION_URL|
|StandardSnowflakeIngestManagerProviderService|HOST_URL|

 

  was:
Currently throughout the Apache NIFI code base there are property descriptors 
which represent URL/URI but do not use URL/URI validation. The likely reason 
for this is because the properties also support Expression Language expressions 
with flow file attributes. But in truth they could still use either 
org.apache.nifi.processor.util.URLValidator or 
org.apache.nifi.processor.util.StandardValidators.URI_VALIDATOR as they both 
support skipping over Expression Language expressions. 

Some examples are detailed in the table below
||Class||Property||
|RestLookupService|URL|
|BitbucketFlowRegistryClient|BITBUCKET_API_URL|
|AzureKeyVaultSecretsParameterProvider|KEY_VAULT_URI|
|DeleteSQS|QUEUE_URL|
|GetSQS|QUEUE_URL|
|PutSQS|QUEUE_URL|
|AbstractAzureLogAnalyticsReportingTask|LOG_ANALYTICS_URL_ENDPOINT_FORMAT|
|AzureLogAnalyticsProvenanceReportingTask|INSTANCE_URL|
|Neo4JCypherClientService|CONNECTION_URL|
|StandardSnowflakeIngestManagerProviderService|HOST_URL|

 


> Introduce URL/URI validation for properties representing a URL/URI
> ------------------------------------------------------------------
>
>                 Key: NIFI-15261
>                 URL: https://issues.apache.org/jira/browse/NIFI-15261
>             Project: Apache NiFi
>          Issue Type: Improvement
>            Reporter: Daniel Stieglitz
>            Assignee: Daniel Stieglitz
>            Priority: Minor
>
> Currently throughout the Apache NIFI code base there are property descriptors 
> which represent URL/URI but do not use URL/URI validation. The likely reason 
> for this is because the properties also support Expression Language 
> expressions with flow file attributes. But in truth they could still use 
> either org.apache.nifi.processor.util.URLValidator,  
> org.apache.nifi.processor.util.StandardValidators.URI_VALIDATOR or 
> org.apache.nifi.processor.util.StandardValidators.URI_LIST_VALIDATOR as they 
> all support skipping over Expression Language expressions. 
> Some examples are detailed in the table below
> ||Class||Property||
> |RestLookupService|URL|
> |BitbucketFlowRegistryClient|BITBUCKET_API_URL|
> |AzureKeyVaultSecretsParameterProvider|KEY_VAULT_URI|
> |DeleteSQS|QUEUE_URL|
> |GetSQS|QUEUE_URL|
> |PutSQS|QUEUE_URL|
> |AbstractAzureLogAnalyticsReportingTask|LOG_ANALYTICS_URL_ENDPOINT_FORMAT|
> |AzureLogAnalyticsProvenanceReportingTask|INSTANCE_URL|
> |Neo4JCypherClientService|CONNECTION_URL|
> |StandardSnowflakeIngestManagerProviderService|HOST_URL|
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to