[ 
https://issues.apache.org/jira/browse/NIFI-15261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18040946#comment-18040946
 ] 

David Handermann commented on NIFI-15261:
-----------------------------------------

1. In most cases, the URI_LIST_VALIDATOR should cover multiple URLs, so I don't 
think a new standard validator is necessarily required. The 
MultipleURLValidator might be replaceable with the URI_LIST_VALIDATOR, but the 
differences would have to be valuated carefully in light of actual valid values 
for Confluent Schema Registries, so this may not be worth changing.

2. This is used in the SlackConfig class, a URL_VALIDATOR could be used

3. There is an important difference between a valid URI and valid URL, so the 
property name does not necessary equate to a corresponding validator, such as 
in the RESTIcebergCatalog.

> Add URL/URI validation for properties representing a URL/URI
> ------------------------------------------------------------
>
>                 Key: NIFI-15261
>                 URL: https://issues.apache.org/jira/browse/NIFI-15261
>             Project: Apache NiFi
>          Issue Type: Improvement
>            Reporter: Daniel Stieglitz
>            Assignee: Daniel Stieglitz
>            Priority: Minor
>          Time Spent: 20m
>  Remaining Estimate: 0h
>
> Currently throughout the Apache NIFI code base there are property descriptors 
> which represent URL/URI but do not use URL/URI validation. Depending on the 
> property, they could use one of the following:
>  * org.apache.nifi.processor.util.URLValidator
>  * org.apache.nifi.processor.util.StandardValidators.URI_VALIDATOR
>  * org.apache.nifi.processor.util.StandardValidators.URI_LIST_VALIDATOR. 
> Some examples are detailed in the table below
> ||Class||Property||
> |RestLookupService|URL|
> |BitbucketFlowRegistryClient|BITBUCKET_API_URL|
> |AzureKeyVaultSecretsParameterProvider|KEY_VAULT_URI|
> |DeleteSQS|QUEUE_URL|
> |GetSQS|QUEUE_URL|
> |PutSQS|QUEUE_URL|
> |AbstractAzureLogAnalyticsReportingTask|LOG_ANALYTICS_URL_ENDPOINT_FORMAT|
> |AzureLogAnalyticsProvenanceReportingTask|INSTANCE_URL|
> |Neo4JCypherClientService|CONNECTION_URL|
> |StandardSnowflakeIngestManagerProviderService|HOST_URL|
> |AbstractMQTTProcessor|PROP_BROKER_URI|
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to