adamdebreceni commented on code in PR #1987:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1987#discussion_r2567625334
##########
minifi-api/include/minifi-cpp/core/ProcessorDescriptor.h:
##########
@@ -28,6 +28,7 @@ class ProcessorDescriptor {
virtual void setSupportedRelationships(std::span<const
RelationshipDefinition> relationships) = 0;
virtual void setSupportedProperties(std::span<const PropertyReference>
properties) = 0;
+ virtual void setSupportedProperties(std::span<const Property> properties) =
0;
Review Comment:
we previously had a `Property::getReference` that worked incorrectly
discarding `types` and `allowed_values`, since despite its name a `Property` is
not easy to convert to `PropertyReference`, the former stores
`std::vector<std::string>` while the latter uses `std::span<const
std::string_view>` (this caused an issue in python processors as well)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
