[ 
https://issues.apache.org/jira/browse/NIFI-15281?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18041985#comment-18041985
 ] 

Daniel Stieglitz commented on NIFI-15281:
-----------------------------------------

[~exceptionfactory] Unit test test10MIterationsWithQuery in 
TestStandardPreparedQuery is disabled with reason "Takes too long". Would this 
test also be a candidate to replace with 
@EnabledIfSystemProperty(named = "nifi.test.performance", matches = "true", 
disabledReason = "whatever specific reason")
?

> Change disabled unit tests due to the reason "Intended for manual performance 
> testing", to be conditional on system property nifi.test.performance being set
> ------------------------------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: NIFI-15281
>                 URL: https://issues.apache.org/jira/browse/NIFI-15281
>             Project: Apache NiFi
>          Issue Type: Improvement
>            Reporter: Daniel Stieglitz
>            Assignee: Daniel Stieglitz
>            Priority: Minor
>
> There are many unit tests disabled for the reason 
> {code:java}
> "Intended for manual performance testing; should not be run in an automated 
> environment"{code}
> or the like. They should be changed to be contingent on whether system 
> property nifi.test.performance is set like in similar tests with the use of 
> JUnit 5 EnabledIfSystemProperty annotation 
> e.g.
> {code:java}
> @EnabledIfSystemProperty(named = "nifi.test.performance", matches = "true", 
> disabledReason = "whatever specific reason"){code}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to