mcgilman commented on code in PR #10583:
URL: https://github.com/apache/nifi/pull/10583#discussion_r2579223155
##########
nifi-frontend/src/main/frontend/apps/nifi/src/app/pages/flow-designer/service/queue.service.ts:
##########
@@ -42,11 +40,15 @@ export class QueueService {
);
}
- pollEmptyQueueRequest(dropRequest: DropRequest): Observable<any> {
- return
this.httpClient.get(this.nifiCommon.stripProtocol(dropRequest.uri));
+ pollEmptyQueueRequest(request: EmptyQueueRequest): Observable<any> {
+ return this.httpClient.get(
+
`${QueueService.API}/flowfile-queues/${request.connectionId}/drop-requests/${request.dropRequestId}`
+ );
Review Comment:
We may need to introduce a new method pollEmptyQueuesRequest and call the
appropriate one from the effects based on the action.
##########
nifi-frontend/src/main/frontend/apps/nifi/src/app/pages/flow-designer/service/queue.service.ts:
##########
@@ -42,11 +40,15 @@ export class QueueService {
);
}
- pollEmptyQueueRequest(dropRequest: DropRequest): Observable<any> {
- return
this.httpClient.get(this.nifiCommon.stripProtocol(dropRequest.uri));
+ pollEmptyQueueRequest(request: EmptyQueueRequest): Observable<any> {
+ return this.httpClient.get(
+
`${QueueService.API}/flowfile-queues/${request.connectionId}/drop-requests/${request.dropRequestId}`
+ );
}
- deleteEmptyQueueRequest(dropRequest: DropRequest): Observable<any> {
- return
this.httpClient.delete(this.nifiCommon.stripProtocol(dropRequest.uri));
+ deleteEmptyQueueRequest(request: EmptyQueueRequest): Observable<any> {
+ return this.httpClient.delete(
+
`${QueueService.API}/flowfile-queues/${request.connectionId}/drop-requests/${request.dropRequestId}`
+ );
Review Comment:
We may need to introduce a new method pollEmptyQueuesRequest and call the
appropriate one from the effects based on the action.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
