dan-s1 commented on code in PR #10607:
URL: https://github.com/apache/nifi/pull/10607#discussion_r2593795453
##########
nifi-extension-bundles/nifi-azure-bundle/nifi-azure-processors/src/main/java/org/apache/nifi/processors/azure/storage/queue/AbstractAzureQueueStorage_v12.java:
##########
@@ -110,6 +111,7 @@ public Set<Relationship> getRelationships() {
@Override
public void migrateProperties(PropertyConfiguration config) {
config.renameProperty(AzureStorageUtils.STORAGE_ENDPOINT_SUFFIX_PROPERTY_DESCRIPTOR_NAME,
ENDPOINT_SUFFIX.getName());
+ ProxyServiceMigration.renameProxyConfigurationServiceProperty(config);
Review Comment:
Since the migration is happening in the parent class, wouldn't it make sense
to define the property with value
`ProxyConfiguration.createProxyConfigPropertyDescriptor(PROXY_SPECS)` in this
class and have it shared with its children `GetAzureQueueStorage_v12` and
`PutAzureQueueStorage_v12` instead of making this call in both children?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
