exceptionfactory commented on code in PR #10617: URL: https://github.com/apache/nifi/pull/10617#discussion_r2604507420
########## nifi-commons/nifi-record/src/test/java/org/apache/nifi/serialization/record/field/ObjectLocalTimeFieldConverterTest.java: ########## @@ -0,0 +1,55 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.nifi.serialization.record.field; + +import org.junit.jupiter.params.ParameterizedTest; +import org.junit.jupiter.params.provider.MethodSource; + +import java.time.LocalDate; +import java.time.LocalTime; +import java.time.ZoneId; +import java.time.ZonedDateTime; +import java.time.format.DateTimeFormatter; +import java.util.Optional; + +import static org.junit.jupiter.api.Assertions.assertEquals; + +class ObjectLocalTimeFieldConverterTest { + + private static final ObjectLocalTimeFieldConverter CONVERTER = new ObjectLocalTimeFieldConverter(); + + private static final String FIELD_NAME = LocalTime.class.getSimpleName(); + + private static final String TIME_DEFAULT = "12:30:45"; + + private static final String TIME_WITH_OFFSET_PATTERN = "HH:mm:ssXXX"; + + @ParameterizedTest + @MethodSource("org.apache.nifi.serialization.record.field.DateTimeTestUtil#offsetSource") + void testConvertFieldStringWithTimeOffset(final String offset) { + final String timeString = TIME_DEFAULT + offset; + + final LocalTime expected = ZonedDateTime.of(LocalDate.EPOCH, LocalTime.parse(timeString, DateTimeFormatter.ofPattern(TIME_WITH_OFFSET_PATTERN)), ZoneId.of(offset)) + .withZoneSameInstant(ZoneId.systemDefault()) + .toLocalTime(); Review Comment: The levels of nesting make this declaration rather hard to follow. On closer analysis, I think a different approach is needed. The parsing and conversion from `LocalTime` to `ZonedDateTime` and back to `LocalTime` effectively do something similar to what the `FieldConverter` itself is doing. The challenge is `LocalTime` is different based on where it is running. However, the main goal of the comparison should be that the `FieldConverter` shifts the hours forward or backward, based on the relative offset. The issue is that the number of hours is different based on the JVM system default zone. That's the reason for limiting the test to the offset of the system default zone, versus attempting to test other offsets. With that background, it would help break up the declaration of each variable, as opposed to nesting the parsing and construction of different values. That should make it somewhat easier to understand how the expected value is being constructed. I can take a closer look at providing an alternative if that would be helpful. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
