[
https://issues.apache.org/jira/browse/NIFI-15335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18045204#comment-18045204
]
Daniel Stieglitz edited comment on NIFI-15335 at 12/15/25 3:56 PM:
-------------------------------------------------------------------
[~pvillard] [~exceptionfactory]
I am trying to write a unit test for AWSCredentialsProviderControllerService
but I am not understanding why there is the following renaming of property
{code:java}
proxy-configuration-service{code}
to
{code:java}
Proxy Configuration Service{code}
That renaming is necessary when the class created that property with method
createProxyConfigPropertyDescriptor found in
org.apache.nifi.proxy.ProxyConfiguration. But in the case of
AWSCredentialsProviderControllerService it did not call this method rather it
defined its own property named
{code:java}
ASSUME_ROLE_PROXY_CONFIGURATION_SERVICE{code}
The call to ProxyServiceMigration.migrateProxyProperties in
AWSCredentialsProviderControllerService migrateProperties method is causing the
aforementioned renaming (as it calls an overloaded method
migrateProxyProperties method which first calls
renameProxyConfigurationServiceProperty(config)) but as I said I think it
should not be. Please advise.
was (Author: JIRAUSER294662):
[~pvillard] [~exceptionfactory]
I am trying to write a unit test for AWSCredentialsProviderControllerService
but I am not understanding why there is the following renaming of property
{code:java}
proxy-configuration-service{code}
to
{code:java}
Proxy Configuration Service{code}
That renaming is necessary when the class created that property with method
createProxyConfigPropertyDescriptor found in
org.apache.nifi.proxy.ProxyConfiguration. But in the case of
AWSCredentialsProviderControllerService it did not call this method rather it
defined its own property named
{code:java}
ASSUME_ROLE_PROXY_CONFIGURATION_SERVICE{code}
The call to ProxyServiceMigration.migrateProxyProperties in
AWSCredentialsProviderControllerService migrateProperties method is causing the
aforementioned renaming but as I said I think it should not be. Please advise.
> Create migration property unit tests for those components in extended bundles
> nifi-airtable-bundle, nifi-amqp-bundle, nifi-asana-bundle, nifi-asn1-bundle
> and nifi-aws-bundle which do not have these unit tests.
> -----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: NIFI-15335
> URL: https://issues.apache.org/jira/browse/NIFI-15335
> Project: Apache NiFi
> Issue Type: Improvement
> Reporter: Daniel Stieglitz
> Assignee: Daniel Stieglitz
> Priority: Minor
>
> In NIFI-14892 there was an addition of migrationProperties across many
> components in extended bundles nifi-airtable-bundle, nifi-amqp-bundle,
> nifi-asana-bundle, nifi-asn1-bundle and nifi-aws-bundle. Some had unit tests
> added and other did not. The purpose of this ticket is to add unit tests to
> those components missing ones.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
