markap14 commented on code in PR #10665:
URL: https://github.com/apache/nifi/pull/10665#discussion_r2635315057


##########
nifi-system-tests/nifi-system-test-suite/src/test/java/org/apache/nifi/tests/system/NiFiClientUtil.java:
##########
@@ -397,6 +397,27 @@ public void waitForConnectorValidationStatus(final String 
connectorId, final Str
         }
     }
 
+    public void waitForConnectorStopped(final String connectorId) throws 
NiFiClientException, IOException, InterruptedException {
+        waitForConnectorState(connectorId, ConnectorState.STOPPED);
+    }
+
+    public void waitForConnectorState(final String connectorId, final 
ConnectorState desiredState) throws InterruptedException, NiFiClientException, 
IOException {
+        int iteration = 0;
+        while (true) {

Review Comment:
   Yeah, we generally don't worry about this because the base class, 
`NiFiSystemIT` has the following annotation, which trickles down to all tests 
that don't override it:
   ```
   @Timeout(value = 5, unit = TimeUnit.MINUTES)
   ```
   So we just assume that the test doesn't work and it waits forever, that 5 
minute timeout will eventually kick in and kill the test.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to