gresockj commented on code in PR #10675:
URL: https://github.com/apache/nifi/pull/10675#discussion_r2636619536
##########
nifi-framework-bundle/nifi-framework/nifi-framework-components/src/main/java/org/apache/nifi/controller/service/StandardControllerServiceResolver.java:
##########
@@ -168,27 +171,57 @@ private void resolveInheritedControllerServices(final
VersionedConfigurableExten
continue;
Review Comment:
Although this is secondary to the concern at hand, what do you think about
removing line 164, as seen below:
```
// If the referenced Controller Service is available, there is
nothing to resolve.
if (availableControllerServiceIds.contains(propertyValue)) {
unresolvedServices.add(propertyValue); // Line 164
continue;
}
```
If the comment is correct, I believe we should not be adding an identifier
to the `unresolvedServices` here. I spoke briefly to @mcgilman and he agreed
that this was likely a mistake.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
