exceptionfactory commented on code in PR #10664:
URL: https://github.com/apache/nifi/pull/10664#discussion_r2637165479
##########
nifi-extension-bundles/nifi-aws-bundle/nifi-aws-kinesis/src/test/java/org/apache/nifi/processors/aws/kinesis/ConsumeKinesisTest.java:
##########
@@ -65,14 +74,28 @@ void getRelationshipsForRecordProcessingStrategy() {
}
@Test
+ // It takes around 30 seconds for a scheduler to fail in this test.
+ @Timeout(value = 3, unit = TimeUnit.MINUTES, threadMode = SEPARATE_THREAD)
Review Comment:
This is too long for a unit test. One option is moving this to an
integration test. Another option is to remove the test method.
##########
nifi-extension-bundles/nifi-aws-bundle/nifi-aws-kinesis/src/main/java/org/apache/nifi/processors/aws/kinesis/ConsumeKinesis.java:
##########
@@ -339,6 +340,9 @@ Ensure that the credentials provided have access to
Kinesis, DynamoDB and (optio
private volatile @Nullable ReaderRecordProcessor readerRecordProcessor;
+ private volatile Future<InitializationResult> initializationResultFuture;
+ private volatile AtomicBoolean initialized;
Review Comment:
Recommend setting a final value to avoid null checking.
```suggestion
private final AtomicBoolean initialized = new AtomicBoolean();
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
