ofekR123 opened a new pull request, #10677: URL: https://github.com/apache/nifi/pull/10677
<!-- Licensed to the Apache Software Foundation (ASF) under one or more --> <!-- contributor license agreements. See the NOTICE file distributed with --> <!-- this work for additional information regarding copyright ownership. --> <!-- The ASF licenses this file to You under the Apache License, Version 2.0 --> <!-- (the "License"); you may not use this file except in compliance with --> <!-- the License. You may obtain a copy of the License at --> <!-- http://www.apache.org/licenses/LICENSE-2.0 --> <!-- Unless required by applicable law or agreed to in writing, software --> <!-- distributed under the License is distributed on an "AS IS" BASIS, --> <!-- WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. --> <!-- See the License for the specific language governing permissions and --> <!-- limitations under the License. --> # Summary [NIFI-15244](https://issues.apache.org/jira/browse/NIFI-15244) This pull request addresses an issue in the **LengthDelimitedJournal.update()** method where a journal file update failure could result in FlowFiles being duplicated in their original queue during rollback. During a checkpoint operation, NiFi creates a new journal file and attempts to write a header to it. If this operation fails (for example, due to disk-related issues), the journal file remains in an invalid state and cannot be updated until a checkpoint occurs. Once the journal file enters this state, every subsequent attempt to update it results in an **IllegalStateException**, including cases where there are no records to be written. When NiFi attempts to commit a processor session, the journal update fails and triggers a rollback. The rollback logic itself invokes a journal update, and even when the record collection is empty, this update attempt fails with the same **IllegalStateException**. Prior to this change, the rollback-related conditions within the **update()** method were evaluated in an order that allowed the same FlowFile to be re-added multiple times. Because the rollback path was entered repeatedly under the same failure condition, the FlowFile was enqueued more than once, leading to unintended duplication. The root cause was not missing logic, but the ordering of conditional checks within the **update()** method. This change resolves the issue by reordering the relevant conditions, ensuring that journal update failures are handled deterministically and that rollback processing does not result in duplicate FlowFiles being added back to the queue. # Tracking Please complete the following tracking steps prior to pull request creation. ### Issue Tracking - [ ] [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI) issue created ### Pull Request Tracking - [ ] Pull Request title starts with Apache NiFi Jira issue number, such as `NIFI-00000` - [ ] Pull Request commit message starts with Apache NiFi Jira issue number, as such `NIFI-00000` ### Pull Request Formatting - [ ] Pull Request based on current revision of the `main` branch - [ ] Pull Request refers to a feature branch with one commit containing changes # Verification Please indicate the verification steps performed prior to pull request creation. ### Build - [ ] Build completed using `./mvnw clean install -P contrib-check` - [ ] JDK 21 - [ ] JDK 25 ### Licensing - [ ] New dependencies are compatible with the [Apache License 2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License Policy](https://www.apache.org/legal/resolved.html) - [ ] New dependencies are documented in applicable `LICENSE` and `NOTICE` files ### Documentation - [ ] Documentation formatting appears as expected in rendered files -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
