bobpaulin commented on code in PR #10692:
URL: https://github.com/apache/nifi/pull/10692#discussion_r2649228139


##########
nifi-extension-bundles/nifi-standard-services/nifi-dbcp-service-bundle/nifi-hikari-dbcp-service/pom.xml:
##########
@@ -53,5 +53,29 @@
             <artifactId>nifi-dbcp-utils</artifactId>
             <version>2.8.0-SNAPSHOT</version>
         </dependency>
+        <dependency>
+            <groupId>org.apache.derby</groupId>
+            <artifactId>derby</artifactId>

Review Comment:
   Yes this make sense.  I was keeping it consistent with the DBCP tests that 
are making use of Apache Derby within the same bundle.  I've used H2 for 
similar test usecases in the past.  Not sure if that is under consideration.  
https://www.h2database.com/html/license.html



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to