[
https://issues.apache.org/jira/browse/NIFI-3319?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15864514#comment-15864514
]
ASF GitHub Bot commented on NIFI-3319:
--------------------------------------
GitHub user brosander opened a pull request:
https://github.com/apache/nifi/pull/1502
NIFI-3319 - Making default output directory calculation more robust
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [X] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [X] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number
you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [X] Has your PR been rebased against the latest commit within the target
branch (typically master)?
- [X] Is your initial contribution a single, squashed commit?
### For code changes:
- [X] Have you ensured that the full suite of tests is executed via mvn
-Pcontrib-check clean install at the root nifi folder?
- [X] Have you written or updated unit tests to verify your changes?
- [X] - N/A - If adding new dependencies to the code, are these
dependencies licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [X] - N/A - If applicable, have you updated the LICENSE file, including
the main LICENSE file under nifi-assembly?
- [X] - N/A - If applicable, have you updated the NOTICE file, including
the main NOTICE file found under nifi-assembly?
- [X] - N/A - If adding new Properties, have you added .displayName in
addition to .name (programmatic access) for each of the new properties?
### For documentation related changes:
- [X] - N/A - Have you ensured that format looks appropriate for the output
in which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build
issues and submit an update to your PR as soon as possible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/brosander/nifi NIFI-3319
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/1502.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1502
----
commit f3b151b9580aed25555ba893ca478592af1ea036
Author: Bryan Rosander <[email protected]>
Date: 2017-02-13T21:44:50Z
NIFI-3319 - Making default output directory calculation more robust
----
> TLS toolkit throws NPE when accessed from root level
> ----------------------------------------------------
>
> Key: NIFI-3319
> URL: https://issues.apache.org/jira/browse/NIFI-3319
> Project: Apache NiFi
> Issue Type: Bug
> Components: Tools and Build
> Affects Versions: 1.1.1
> Reporter: Aldrin Piri
> Assignee: Bryan Rosander
>
> If accessing the TLS toolkit from a root level ( '/' on those using the *.sh
> tooling, presumably the same would occur in *.bat envs), an NPE is thrown due
> to how the Default Output Directory is calculated.
> {code}
> public static final String DEFAULT_OUTPUT_DIRECTORY = "../" +
> Paths.get(".").toAbsolutePath().normalize().getFileName().toString();
> {code}
> Stacktrace
> {noformat}
> / # /opt/nifi/bin/tls-toolkit.sh standalone -h
> Exception in thread "main" java.lang.ExceptionInInitializerError
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:498)
> at
> org.apache.nifi.toolkit.tls.TlsToolkitMain.doMain(TlsToolkitMain.java:107)
> at
> org.apache.nifi.toolkit.tls.TlsToolkitMain.main(TlsToolkitMain.java:53)
> Caused by: java.lang.NullPointerException
> at
> org.apache.nifi.toolkit.tls.standalone.TlsToolkitStandaloneCommandLine.<clinit>(TlsToolkitStandaloneCommandLine.java:62)
> ... 6 more
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
