exceptionfactory commented on code in PR #10700:
URL: https://github.com/apache/nifi/pull/10700#discussion_r2651319285
##########
nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/src/main/java/org/apache/nifi/web/api/FlowResource.java:
##########
@@ -1357,6 +1357,13 @@ public Response clearBulletins(
clearBulletinsForGroupRequestEntity.setComponents(writableComponentIds);
}
+ // If there are no components to clear bulletins for, return success
with 0 bulletins cleared
+ if (clearBulletinsForGroupRequestEntity.getComponents().isEmpty()) {
Review Comment:
It seems like this conditional should be added to the earlier check for a
`null` list of Components. In that case, the absence of Components is
interpreted to mean all Components in the Process Group. Handling `null` and an
empty list in the same way seems more consistent. What do you think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
