NissimShiman commented on code in PR #10696:
URL: https://github.com/apache/nifi/pull/10696#discussion_r2653261800
##########
nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/src/main/java/org/apache/nifi/audit/ProcessGroupAuditor.java:
##########
@@ -273,6 +276,21 @@ private List<Action> getComponentActions(final String
groupId, final Collection<
port = processGroup.findOutputPort(componentId);
if (port != null) {
actions.add(generateUpdateConnectableAction(port, operation,
Component.OutputPort));
+ continue;
+ }
+
+ ProcessGroup internalProcessGroup =
processGroup.findProcessGroup(componentId);
+ if (internalProcessGroup != null) {
+
actions.add(generateUpdateProcessGroupAction(internalProcessGroup, operation));
+ continue;
+ }
+
+ RemoteGroupPort remoteGroupPort =
processGroup.findRemoteGroupPort(componentId);
+ if (remoteGroupPort != null) {
+ RemoteProcessGroup remoteProcessGroup =
remoteGroupPort.getRemoteProcessGroup();
+ if (remoteProcessGroup != null) {
+
actions.add(generateUpdateRemoteProcessGroupAction(remoteProcessGroup,
operation));
+ }
}
Review Comment:
Yes, this is the intended behavior.
We don't capture Remote Port in the flow history auditing. [1]
Any actions done to the remote port are captured as being done to the RPG.
[2]
[1] [List of capturable
components](https://github.com/apache/nifi-api/blob/nifi-api-2.5.0/src/main/java/org/apache/nifi/action/Component.java)
[2] There is auditing done for remote port
[here](https://github.com/apache/nifi/blob/rel/nifi-2.7.2/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/src/main/java/org/apache/nifi/audit/RemoteProcessGroupAuditor.java#L412)
as well.
It is ultimately also captured as a
[remotePG](https://github.com/apache/nifi/blob/rel/nifi-2.7.2/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/src/main/java/org/apache/nifi/audit/RemoteProcessGroupAuditor.java#L326)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
