pvillard31 opened a new pull request, #10712: URL: https://github.com/apache/nifi/pull/10712
# Summary NIFI-15406 Add Checkstyle rules for code quality and Java 15+ best practices Added the following Checkstyle rules: - NewlineAtEndOfFile: Ensure files end with a newline - UpperEll: Use uppercase 'L' for long literals - OuterTypeFilename: Outer type name must match filename - EqualsHashCode: Ensure equals() and hashCode() are defined together - FallThrough: Require fall-through comments in switch statements - StringLiteralEquality: Use equals() instead of == for String comparison - CovariantEquals: Prevent covariant equals() definitions - DefaultComesLast: Default case should be last in switch - SimplifyBooleanExpression: Simplify boolean expressions - SimplifyBooleanReturn: Simplify boolean return statements - MissingOverride: Require @Override annotation - EmptyStatement: Detect empty statements - NeedBraces: Require braces for control statements - ModifierOrder: Enforce JLS modifier order - MultipleVariableDeclarations: One variable per declaration - OneStatementPerLine: One statement per line - AvoidNoArgumentSuperConstructorCall: Remove redundant super() - PatternVariableName: Naming convention for pattern variables (Java 16+) - RecordComponentName: Naming convention for record components (Java 16+) - IllegalIdentifierName: Prevent reserved identifiers like 'var' (Java 10+) - UnnecessarySemicolonInTryWithResources: Remove extra semicolons - UnnecessarySemicolonAfterTypeMemberDeclaration: Remove extra semicolons # Tracking Please complete the following tracking steps prior to pull request creation. ### Issue Tracking - [ ] [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI) issue created ### Pull Request Tracking - [ ] Pull Request title starts with Apache NiFi Jira issue number, such as `NIFI-00000` - [ ] Pull Request commit message starts with Apache NiFi Jira issue number, as such `NIFI-00000` - [ ] Pull request contains [commits signed](https://docs.github.com/en/authentication/managing-commit-signature-verification/signing-commits) with a registered key indicating `Verified` status ### Pull Request Formatting - [ ] Pull Request based on current revision of the `main` branch - [ ] Pull Request refers to a feature branch with one commit containing changes # Verification Please indicate the verification steps performed prior to pull request creation. ### Build - [ ] Build completed using `./mvnw clean install -P contrib-check` - [ ] JDK 21 - [ ] JDK 25 ### Licensing - [ ] New dependencies are compatible with the [Apache License 2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License Policy](https://www.apache.org/legal/resolved.html) - [ ] New dependencies are documented in applicable `LICENSE` and `NOTICE` files ### Documentation - [ ] Documentation formatting appears as expected in rendered files -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
