[ 
https://issues.apache.org/jira/browse/NIFI-3474?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15864929#comment-15864929
 ] 

Joseph Witt commented on NIFI-3474:
-----------------------------------

Yeah I believe it is a no-fix.  Will defer to [~randy_b] as the requester.  
There are two aspects of concern:

1) What if a flow file comes in with no attribute containing a valid IP address?
 - avoid this by having RouteOnAttribute validate the input before sending to 
this processor

2) What if the ip address attribute results in a no-lookup?   
- this case of causing exceptions has already been resolved in the existing 
GeoEnrich processor.  The maxmind reader was overridden to fix this behavior 
and actually I believe this was the reason for this ticket.  Believe this is an 
OBE.

I think all cases are well covered now.

> GeoEnrich - stop using exceptions for mainline flow control.
> ------------------------------------------------------------
>
>                 Key: NIFI-3474
>                 URL: https://issues.apache.org/jira/browse/NIFI-3474
>             Project: Apache NiFi
>          Issue Type: Bug
>            Reporter: Randy Bovay
>            Assignee: Andre
>            Priority: Minor
>
> modification to the code to stop using exceptions for mainline flow control. 
> Specifically we don't want to throw an exception simply because an address 
> was not found.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to