exceptionfactory commented on code in PR #10714:
URL: https://github.com/apache/nifi/pull/10714#discussion_r2656674794
##########
.github/workflows/code-coverage.yml:
##########
@@ -62,9 +62,66 @@ jobs:
-P report-code-coverage
jacoco:prepare-agent
verify
- - name: Codecov
+ - name: Upload Coverage to Codecov
uses: codecov/codecov-action@v5
if: github.repository_owner == 'apache'
with:
files: ./nifi-code-coverage/target/site/jacoco-aggregate/jacoco.xml
+ flags: unit-tests
+ token: ${{ secrets.CODECOV_TOKEN }}
+
+ integration-tests:
+ timeout-minutes: 120
+ runs-on: ubuntu-24.04
+ name: Run Integration Tests
+ env:
+ # Skip assemblies and modules covered separately by the system-tests
workflow
+ # Skip unit tests (surefire), run integration tests (failsafe)
+ MAVEN_BUILD_ARGUMENTS: >-
+ verify
+ -P skip-unit-tests
+ -P integration-tests
+ jacoco:prepare-agent
+ jacoco:report
+ MAVEN_BUILD_EXCLUDE_PROJECTS: >-
+ -pl -:minifi-assembly
+ -pl -:nifi-assembly
+ -pl -:nifi-toolkit-assembly
+ -pl -:nifi-registry-assembly
+ -pl -:nifi-registry-toolkit-assembly
+ -pl -:nifi-runtime-manifest
+ -pl -:nifi-runtime-manifest-test
+ -pl -:nifi-stateless-assembly
+ -pl -:nifi-stateless-system-test-suite
+ -pl -:nifi-system-test-suite
+ -pl -:nifi-nar-provider-assembly
+ -pl -:nifi-py4j-integration-tests
+ -pl -:nifi-docs
+ -pl -:nifi-maven-archetypes
+ -pl -:nifi-processor-bundle-archetype
+ -pl -:nifi-service-bundle-archetype
+ steps:
+ - name: Checkout Code
+ uses: actions/checkout@v6
+ - name: Set up Java 21
+ uses: actions/setup-java@v5
+ with:
+ distribution: 'zulu'
+ java-version: 21
+ cache: 'maven'
+ - name: Maven Integration Tests with Coverage
+ env:
+ MAVEN_OPTS: >-
+ ${{ env.DEFAULT_MAVEN_OPTS }}
+ TESTCONTAINERS_REUSE_ENABLE: true
+ run: >
+ ./mvnw --fail-fast --no-snapshot-updates --no-transfer-progress
--show-version
+ ${{ env.MAVEN_BUILD_ARGUMENTS }}
+ ${{ env.MAVEN_BUILD_EXCLUDE_PROJECTS }}
+ - name: Upload Coverage to Codecov
+ uses: codecov/codecov-action@v5
+ if: github.repository_owner == 'apache' &&
steps.find-reports.outputs.reports != ''
+ with:
+ files: ${{ steps.find-reports.outputs.reports }}
Review Comment:
I looks like this needs to be adjusted to find reports across all
directories.
##########
.github/workflows/code-coverage.yml:
##########
@@ -62,9 +62,66 @@ jobs:
-P report-code-coverage
jacoco:prepare-agent
verify
- - name: Codecov
+ - name: Upload Coverage to Codecov
uses: codecov/codecov-action@v5
if: github.repository_owner == 'apache'
with:
files: ./nifi-code-coverage/target/site/jacoco-aggregate/jacoco.xml
+ flags: unit-tests
+ token: ${{ secrets.CODECOV_TOKEN }}
+
+ integration-tests:
+ timeout-minutes: 120
+ runs-on: ubuntu-24.04
+ name: Run Integration Tests
+ env:
+ # Skip assemblies and modules covered separately by the system-tests
workflow
+ # Skip unit tests (surefire), run integration tests (failsafe)
+ MAVEN_BUILD_ARGUMENTS: >-
+ verify
+ -P skip-unit-tests
+ -P integration-tests
+ jacoco:prepare-agent
+ jacoco:report
+ MAVEN_BUILD_EXCLUDE_PROJECTS: >-
+ -pl -:minifi-assembly
+ -pl -:nifi-assembly
+ -pl -:nifi-toolkit-assembly
+ -pl -:nifi-registry-assembly
+ -pl -:nifi-registry-toolkit-assembly
+ -pl -:nifi-runtime-manifest
+ -pl -:nifi-runtime-manifest-test
+ -pl -:nifi-stateless-assembly
+ -pl -:nifi-stateless-system-test-suite
+ -pl -:nifi-system-test-suite
+ -pl -:nifi-nar-provider-assembly
+ -pl -:nifi-py4j-integration-tests
+ -pl -:nifi-docs
+ -pl -:nifi-maven-archetypes
+ -pl -:nifi-processor-bundle-archetype
+ -pl -:nifi-service-bundle-archetype
+ steps:
+ - name: Checkout Code
+ uses: actions/checkout@v6
+ - name: Set up Java 21
+ uses: actions/setup-java@v5
+ with:
+ distribution: 'zulu'
+ java-version: 21
+ cache: 'maven'
+ - name: Maven Integration Tests with Coverage
+ env:
+ MAVEN_OPTS: >-
+ ${{ env.DEFAULT_MAVEN_OPTS }}
+ TESTCONTAINERS_REUSE_ENABLE: true
+ run: >
+ ./mvnw --fail-fast --no-snapshot-updates --no-transfer-progress
--show-version
+ ${{ env.MAVEN_BUILD_ARGUMENTS }}
+ ${{ env.MAVEN_BUILD_EXCLUDE_PROJECTS }}
+ - name: Upload Coverage to Codecov
+ uses: codecov/codecov-action@v5
+ if: github.repository_owner == 'apache' &&
steps.find-reports.outputs.reports != ''
Review Comment:
With the removal of `find-reports`, this conditional should be simplified:
```suggestion
if: github.repository_owner == 'apache'
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
