pvillard31 opened a new pull request, #10725:
URL: https://github.com/apache/nifi/pull/10725
# Summary
NIFI-15420 - Add checkstyle rule for import ordering
While this requires a large number of changes, this will put us in a much
better position going forward avoiding PRs where imports may have been
automatically re-ordered because of the IDE settings.
I checked many possible configurations to find something that is both
useful/legit and not raising a crazy number of violations (this config is about
11k violations, when the Google Style rule is 30k+ violations).
I'm suggesting this rule:
```xml
<module name="CustomImportOrder">
<property name="customImportOrderRules"
value="THIRD_PARTY_PACKAGE###SPECIAL_IMPORTS###STANDARD_JAVA_PACKAGE###STATIC"/>
<property name="sortImportsInGroupAlphabetically" value="true"/>
<property name="separateLineBetweenGroups" value="true"/>
<property name="standardPackageRegExp" value="^(java|javax)\."/>
</module>
```
And I am also using a maven plugin to help with most of the work (it still
needs small manual updates after that)
```
mvn net.revelc.code:impsort-maven-plugin:1.12.0:sort \
-Dimpsort.staticGroups='*' \
-Dimpsort.groups='*,java.,javax.' \
-Dimpsort.staticAfter=true \
-DskipTests=true
```
# Tracking
Please complete the following tracking steps prior to pull request creation.
### Issue Tracking
- [ ] [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI) issue
created
### Pull Request Tracking
- [ ] Pull Request title starts with Apache NiFi Jira issue number, such as
`NIFI-00000`
- [ ] Pull Request commit message starts with Apache NiFi Jira issue number,
as such `NIFI-00000`
- [ ] Pull request contains [commits
signed](https://docs.github.com/en/authentication/managing-commit-signature-verification/signing-commits)
with a registered key indicating `Verified` status
### Pull Request Formatting
- [ ] Pull Request based on current revision of the `main` branch
- [ ] Pull Request refers to a feature branch with one commit containing
changes
# Verification
Please indicate the verification steps performed prior to pull request
creation.
### Build
- [ ] Build completed using `./mvnw clean install -P contrib-check`
- [ ] JDK 21
- [ ] JDK 25
### Licensing
- [ ] New dependencies are compatible with the [Apache License
2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License
Policy](https://www.apache.org/legal/resolved.html)
- [ ] New dependencies are documented in applicable `LICENSE` and `NOTICE`
files
### Documentation
- [ ] Documentation formatting appears as expected in rendered files
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
