[
https://issues.apache.org/jira/browse/NIFI-4183?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Pierre Villard resolved NIFI-4183.
----------------------------------
Resolution: Feedback Received
Apache NiFi 1.x is no longer maintained and no new release is planned on the
1.x release line. Marking as resolved as part of a cleanup operation. Please
open a new one with an updated description if this is still relevant for NiFi
2.x.
> Fix handshake error logic in SocketFlowFileServerProtocol
> ---------------------------------------------------------
>
> Key: NIFI-4183
> URL: https://issues.apache.org/jira/browse/NIFI-4183
> Project: Apache NiFi
> Issue Type: Bug
> Components: Core Framework
> Affects Versions: 1.3.0
> Reporter: Joe Skora
> Assignee: Joe Skora
> Priority: Minor
> Time Spent: 20m
> Remaining Estimate: 0h
>
> The documentation for SocketFlowFileServerProtocol states that
> `ServerProtocol.isHandshakeSuccessful()` should return `true` if the
> handshake succeeded, but `doHandshake()` currently suppresses the
> `HandshakeException` when it receives an unauthorized, invalid port state, or
> destination full handshake response. The original logic appears to be
> ensuring the final handshake response got sent to the remote system, but it
> is already accounted for in the current logic.
> This change should not affect the existing behavior except to prevent the
> connection from being considered valid when the handshake throws an
> unauthorized, invalid port state, or destination full handshake exception.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)