[
https://issues.apache.org/jira/browse/NIFI-3268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15865165#comment-15865165
]
ASF GitHub Bot commented on NIFI-3268:
--------------------------------------
Github user ijokarumawak commented on the issue:
https://github.com/apache/nifi/pull/1376
@qfdk Thanks for your contribution! Excuse us for taking so long to respond.
Please note that when you submit a PR for a JIRA, push the "submit patch"
button to move JIRA status forward to "Patch Available". This ensure other
developers to know it's ready for PR.
https://cwiki.apache.org/confluence/display/NIFI/Contributor+Guide#ContributorGuide-CodeReviewProcess
I like the idea of using indexed column instead of offset.
I wanted to test this PR. However, the same GenerateTableFetch class is
recently updated by #1407 and this PR is now conflicted to merge.
Would you update this PR by rebasing with the latest master branch and fix
conflicts? And also add Expression support to the "AUTO_INCREMENT(index) column
name" you added?
> Add AUTO_INCREMENT column in GenerateTableFetch to benefit index
> ----------------------------------------------------------------
>
> Key: NIFI-3268
> URL: https://issues.apache.org/jira/browse/NIFI-3268
> Project: Apache NiFi
> Issue Type: Improvement
> Components: Core Framework
> Affects Versions: 1.1.1
> Environment: - ubuntu 16.04
> - java version "1.8.0_111"
> - Java(TM) SE Runtime Environment (build 1.8.0_111-b14)
> - Java HotSpot(TM) 64-Bit Server VM (build 25.111-b14, mixed mode)
> Reporter: qfdk
> Labels: easyfix
> Fix For: 1.2.0
>
>
> I added AUTO_INCREMENT column in GenerateTableFetch to benefit index column
> By default this processor uses OFFSET, i have problems with large data.
> somme column has index so we could use index to speed up query time.
> I posted question here :
> https://community.hortonworks.com/questions/72586/how-can-i-use-an-array-with-putelasticsearch.html
> If you indexed un column (id), you could use this sql
> ```
> select xxx
> From xxxxx
> where 200000=>id
> order by id
> limit 200000
> ```
> “OFFSET is bad for skipping previous rows.” [Online]. Available:
> http://Use-The-Index-Luke.com/sql/partial-results/fetch-next-page. [Accessed:
> 27-Dec-2016].
> Thank you in advance
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
