lordgamez commented on code in PR #2059:
URL: https://github.com/apache/nifi-minifi-cpp/pull/2059#discussion_r2661346735
##########
behave_framework/src/minifi_test_framework/steps/flow_building_steps.py:
##########
@@ -220,3 +224,30 @@ def step_impl(context: MinifiTestContext, service_name:
str, property_name: str,
controller_service = ControllerService(class_name=service_name,
service_name=service_name)
controller_service.add_property(property_name, property_value)
context.get_or_create_default_minifi_container().flow_definition.controller_services.append(controller_service)
+
+
+@given("the \"{property_name}\" property of the {processor_name} processor is
set to match the attribute \"{attribute_key}\" to \"{attribute_value}\"")
+def step_impl(context: MinifiTestContext, property_name: str, processor_name:
str, attribute_key: str, attribute_value: str):
+ processor =
context.get_or_create_default_minifi_container().flow_definition.get_processor(processor_name)
+ if attribute_value == "(not set)":
Review Comment:
I think the `(not set)` parameter is more explicit when used in parameter
tables. The rows in the table list the set parameters for each property, and
`(not set)` specifies better that we do not want to set that specific parameter
than writing `(ignore)` IMO.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
