scottyaslan commented on code in PR #10709:
URL: https://github.com/apache/nifi/pull/10709#discussion_r2661988251
##########
nifi-frontend/src/main/frontend/apps/nifi/src/app/pages/flow-designer/ui/canvas/items/connection/destination/destination-process-group/destination-process-group.component.html:
##########
@@ -20,10 +20,10 @@
<div class="flex flex-col mb-5" data-qa="error-section">
<div data-qa="to-input-error-label">To Input</div>
@if (noPorts) {
- <mat-error data-qa="no-ports-error">{{ groupName }} does not
have any local input ports.</mat-error>
+ <mat-error data-qa="no-ports-error" class="tertiary-color
break-words font-medium w-full">{{ groupName }} does not have any local input
ports.</mat-error>
Review Comment:
Please do not add `tertiary-color` or `font-medium` to mat-error components.
These a colored via angular material theme and follow the typography we have
defined for the entire application.
We also do not need the `break-words` or `w-full` here. Please revert this
change.
##########
nifi-frontend/src/main/frontend/apps/nifi/src/app/pages/flow-designer/ui/canvas/items/connection/destination/destination-process-group/destination-process-group.component.html:
##########
@@ -54,7 +54,7 @@
<div data-qa="within-group-label">Within Group</div>
<div
[title]="groupName"
- class="tertiary-color overflow-ellipsis overflow-hidden
whitespace-nowrap font-medium"
+ class="tertiary-color break-words font-medium w-full"
Review Comment:
Please restore the `overflow-ellipsis overflow-hidden whitespace-nowrap` in
this case. Here we should follow established UX patterns which in this case
would mean the text should have either the `overflow-ellipsis overflow-hidden
whitespace-nowrap` or the `truncated` tailwind classes applied with a title
attribute (which I see is already present in the template).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
