adamdebreceni commented on code in PR #2083:
URL: https://github.com/apache/nifi-minifi-cpp/pull/2083#discussion_r2672103460
##########
libminifi/src/core/RepositoryFactory.cpp:
##########
@@ -44,6 +47,10 @@ std::unique_ptr<core::ContentRepository>
createContentRepository(const std::stri
return
std::make_unique<core::repository::FileSystemRepository>(repo_name);
}
if (fail_safe) {
Review Comment:
I am wondering if this is a good idea (not the change itself) if the user
requests some persistent content repo and we log an error, store stuff
in-memory then it gets wiped, the user might not check the error or even if
they do there might have already been some processing happening and we have no
way of getting to the data
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
