tpalfy commented on PR #10538: URL: https://github.com/apache/nifi/pull/10538#issuecomment-3724361955
@joewitt Thank you for the input. I would be interested in your opinion as well about the PR itself. As I see, the original implementation being too complex and hard to maintain (which was the original argument) is not supported by the change history. It did need 2 fairly serious adjustments, but after that the end result remained stable and correct for many years without the need for change. Maybe I'm missing something here, but I was trying to be very careful to make sure this change works properly. Also, how would we prevent the maintenance burden, coming with the suggested approach of code duplication? Kafka is a hot spot in general, having to duplicate most changes to 2 implementations does feel like a huge tradeoff to me. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
