markap14 commented on code in PR #10779:
URL: https://github.com/apache/nifi/pull/10779#discussion_r2700336708
##########
nifi-framework-bundle/nifi-framework/nifi-framework-core/src/main/java/org/apache/nifi/asset/StandardAssetSynchronizer.java:
##########
@@ -193,19 +220,20 @@ private AssetsEntity listAssets(final AssetsRestApiClient
assetsRestApiClient, f
}
}
- private void synchronizeAssetWithRetry(final AssetsRestApiClient
assetsRestApiClient, final String parameterContextId, final AssetDTO
coordinatorAsset) {
+ private Asset synchronizeAssetWithRetry(final AssetsRestApiClient
assetsRestApiClient, final String parameterContextId, final AssetDTO
coordinatorAsset) {
Review Comment:
@bobpaulin that is fair. And I certainly would support updating to
`Optional` for all methods in this class that might return `null`. But I would
argue that updating those methods is outside of the scope of this Jira/PR. And
I would push against changing only some of the methods to use `Optional`, I
think it needs to be all-or-none. So that said I'd say we should file another
Jira to update that if we want to use `Optional` but not do it here. However,
I'd also like to have @bbende comment as he's the author here. I'm ok with
whatever he decides to go with.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
