[
https://issues.apache.org/jira/browse/NIFI-3389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15865853#comment-15865853
]
ASF GitHub Bot commented on NIFI-3389:
--------------------------------------
Github user markap14 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/1446#discussion_r101047296
--- Diff:
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-core/src/main/java/org/apache/nifi/controller/repository/schema/FlowFileSchema.java
---
@@ -64,4 +65,23 @@
FLOWFILE_SCHEMA_V1 = new RecordSchema(flowFileFields);
}
+
+ static {
--- End diff --
I think the same comment as below applies here as well - we can have a
private static method that takes an argument of type FieldType and builds this
RecordSchema, rather than duplicating all of this code.
> FlowFileSchema writes attribute name and value as STRING instead of
> LONG_STRING
> -------------------------------------------------------------------------------
>
> Key: NIFI-3389
> URL: https://issues.apache.org/jira/browse/NIFI-3389
> Project: Apache NiFi
> Issue Type: Bug
> Affects Versions: 1.1.0
> Reporter: Bryan Rosander
> Assignee: Bryan Rosander
> Priority: Critical
> Labels: regression
>
> This causes errors when the names or values of attributes exceeds 65535 bytes
> when encoded as UTF-8.
> The fix would be pretty trivial but it has backwards compatibility
> implications and the schema will need to be versioned to still be able to
> read old flow files.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
