[
https://issues.apache.org/jira/browse/NIFI-15506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18054659#comment-18054659
]
ASF subversion and git services commented on NIFI-15506:
--------------------------------------------------------
Commit 87f1487136afe25fab58e1bc7f5883ab98c86e3d in nifi's branch
refs/heads/main from dan-s1
[ https://gitbox.apache.org/repos/asf?p=nifi.git;h=87f1487136 ]
NIFI-15506 Replaced mock Processor classes for Controller Services
NoOpProcessor (#10814)
Signed-off-by: David Handermann <[email protected]>
> Replace shell processor test classes used to test controller services with
> org.apache.nifi.util.NoOpProcessor
> --------------------------------------------------------------------------------------------------------------
>
> Key: NIFI-15506
> URL: https://issues.apache.org/jira/browse/NIFI-15506
> Project: Apache NiFi
> Issue Type: Improvement
> Reporter: Daniel Stieglitz
> Assignee: Daniel Stieglitz
> Priority: Minor
> Time Spent: 20m
> Remaining Estimate: 0h
>
> It seems the use of classes
> {code:java}
> nifi-extension-bundles/nifi-standard-services/nifi-lookup-services-bundle/nifi-lookup-services/src/test/java/org/apache/nifi/lookup/TestProcessor.java
>
> {code}
> {code:java}
> nifi-extension-bundles/nifi-aws-bundle/nifi-aws-processors/src/test/java/org/apache/nifi/processors/aws/credentials/provider/service/MockAWSProcessor.java
> {code}
> {code:java}
> nifi-extension-bundles/nifi-standard-services/nifi-record-serialization-services-bundle/nifi-record-serialization-services/src/test/java/org/apache/nifi/serialization/TestRecordReaderProcessor.java{code}
> {code:java}
> nifi-extension-bundles/nifi-standard-services/nifi-record-serialization-services-bundle/nifi-record-serialization-services/src/test/java/org/apache/nifi/serialization/TestRecordSetWriterProcessor.java{code}
> {code:java}
> nifi-extension-bundles/nifi-standard-services/nifi-record-sink-service-bundle/nifi-record-sink-service/src/test/java/org/apache/nifi/record/sink/TestProcessor.java
> {code}
> {code:java}
> nifi-extension-bundles/nifi-elasticsearch-bundle/nifi-elasticsearch-client-service/src/test/java/org/apache/nifi/elasticsearch/TestControllerServiceProcessor.java{code}
> {code:java}
> nifi-extension-bundles/nifi-mongodb-bundle/nifi-mongodb-services/src/test/java/org/apache/nifi/mongodb/TestControllerServiceProcessor.java{code}
> {code:java}
> nifi-extension-bundles/nifi-mongodb-bundle/nifi-mongodb-services/src/test/java/org/apache/nifi/mongodb/TestLookupServiceProcessor.java
>
> {code}
> to test controller services or the use of
> {code:java}
> Mockito.mock(Processor.class){code}
> are not necessary as org.apache.nifi.util.NoOpProcessor fits the same purpose.
> The goal of this ticket is replace all the uses of the aforementioned test
> processor classes as well as the use of Mockito to mock a Processor with the
> use of org.apache.nifi.util.NoOpProcessor and delete the aforementioned test
> processor classes from the code base.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
