exceptionfactory commented on code in PR #10840:
URL: https://github.com/apache/nifi/pull/10840#discussion_r2755766437
##########
nifi-toolkit/nifi-toolkit-client/src/main/java/org/apache/nifi/toolkit/client/ParamContextClient.java:
##########
@@ -40,6 +40,18 @@ public interface ParamContextClient {
ParameterContextUpdateRequestEntity
updateParamContext(ParameterContextEntity paramContext) throws
NiFiClientException, IOException;
+ /**
+ * Directly updates a Parameter Context using PUT (synchronous).
+ * This endpoint will fail if any component is running and referencing a
Parameter in the Parameter Context.
+ * The async update-requests endpoint is typically preferred.
+ *
+ * @param paramContext the parameter context entity to update
+ * @return the updated parameter context entity
+ * @throws NiFiClientException if an error occurs
+ * @throws IOException if an I/O error occurs
+ */
+ ParameterContextEntity updateParamContextDirect(ParameterContextEntity
paramContext) throws NiFiClientException, IOException;
Review Comment:
The word `Direct` is somewhat unclear. Following the behavior, what do you
think about `Sync` or `Synchronous`?
```suggestion
ParameterContextEntity
updateParamContextSynchronous(ParameterContextEntity paramContext) throws
NiFiClientException, IOException;
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
