fgerlits commented on code in PR #2093:
URL: https://github.com/apache/nifi-minifi-cpp/pull/2093#discussion_r2763157622
##########
libminifi/src/c2/C2Agent.cpp:
##########
@@ -890,21 +890,26 @@ void C2Agent::handle_start_stop(const C2ContentResponse&
resp) {
});
};
- if (lowered_response_name == "flow") {
- executeStartStopOnComponent("FlowController");
- } else if (lowered_response_name == "processor") {
- auto processor_id = resp.getStringArgument("processorId");
- if (processor_id) {
- executeStartStopOnComponent(processor_id.value());
+ auto update_state = state::UpdateState::FULLY_APPLIED;
+ try {
+ if (lowered_response_name == "flow") {
+ executeStartStopOnComponent("FlowController");
+ } else if (lowered_response_name == "processor") {
+ if (const auto processor_id = resp.getStringArgument("processorId")) {
+ executeStartStopOnComponent(processor_id.value());
+ } else {
+ logger_->log_warn("Processor start/stop request missing 'processorId'
argument");
Review Comment:
this branch could also set `update_state` to `NOT_APPLIED` (or maybe
`NO_OPERATION`?)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
