martinzink commented on code in PR #2099:
URL: https://github.com/apache/nifi-minifi-cpp/pull/2099#discussion_r2799498234
##########
behave_framework/src/minifi_test_framework/containers/container.py:
##########
@@ -74,7 +79,7 @@ def _configure_volumes_of_container_dirs(self):
self._write_content_to_file(file_path, None, content)
self.volumes[temp_path] = {"bind": directory.path, "mode":
directory.mode}
- def deploy(self) -> bool:
+ def deploy(self, context: "Union[MinifiTestContext, None]") -> bool:
Review Comment:
good idea 👍 ,
https://github.com/apache/nifi-minifi-cpp/pull/2099/changes/925076339be8d82c2e733659bd7d0fa9c0efbd53#diff-b9acc60a55b3f931c457c238886505df8e3401fcb942eae49005cac3f96c397bL82
first it didnt work the trick was this
https://github.com/apache/nifi-minifi-cpp/pull/2099/changes/f125497e7c963031414ed2e57f8235a6939e1d7b
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
