mcgilman commented on code in PR #10893:
URL: https://github.com/apache/nifi/pull/10893#discussion_r2806183215
##########
nifi-frontend/src/main/frontend/apps/nifi/src/app/pages/flow-designer/service/manager/connection-manager.service.ts:
##########
@@ -595,9 +595,9 @@ export class ConnectionManager implements OnDestroy {
*/
private isExpirationConfigured(connection: any): boolean {
if (connection.flowFileExpiration != null) {
- const match: string[] =
connection.flowFileExpiration.match(/^(\d+).*/);
+ const match: string[] =
connection.flowFileExpiration.match(/^(\d*\.?\d+).*/);
if (match !== null && match.length > 0) {
- if (parseInt(match[0], 10) > 0) {
+ if (parseFloat(match[0]) > 0) {
Review Comment:
Thanks for adding additional test coverage. Please run `prettier` to ensure
the indentation is consistent. From
`<NIFI_HOME>/nifi-frontend/src/main/frontend` please run:
`npx prettier --write
apps/nifi/src/app/pages/flow-designer/service/manager/connection-manager.service.spec.ts`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
