fgerlits commented on code in PR #2095:
URL: https://github.com/apache/nifi-minifi-cpp/pull/2095#discussion_r2823053097
##########
behave_framework/src/minifi_test_framework/steps/core_steps.py:
##########
@@ -147,6 +147,16 @@ def step_impl(context: MinifiTestContext):
context.containers["nifi"] = NifiContainer(context)
+@step("a NiFi container is set up with SSL enabled")
+def step_impl(context: MinifiTestContext):
+ context.containers["nifi"] = NifiContainer(context, use_ssl=True)
+
+
+@when(u'NiFi is started')
Review Comment:
nitpick: `u` can be deleted
##########
behave_framework/src/minifi_test_framework/steps/configuration_steps.py:
##########
@@ -50,6 +50,11 @@ def step_impl(context: MinifiTestContext):
context.get_or_create_default_minifi_container().fetch_flow_config_from_flow_url()
+@given("SSL properties are set in MiNiFi")
+def step_impl(context: MinifiTestContext):
+ context.get_or_create_default_minifi_container().set_up_ssl_proprties()
Review Comment:
typo:
```suggestion
context.get_or_create_default_minifi_container().set_up_ssl_properties()
```
I think this is already fixed in MinifiContainer, just needs a rebase.
##########
behave_framework/src/minifi_test_framework/minifi/nifi_flow_definition.py:
##########
@@ -113,9 +113,22 @@ def to_json(self) -> str:
connections_node = config["rootGroup"]["connections"]
+ processors_by_name = {p.name: p for p in self.processors}
+ input_ports_by_name = {port.name: port for port in self.input_ports}
+ output_ports_by_name = {port.name: port for port in self.output_ports}
+
for conn in self.connections:
+ source_type = "PROCESSOR"
source_proc = processors_by_name.get(conn.source_name)
+ if not source_proc:
+ source_proc = input_ports_by_name.get(conn.source_name)
+ source_type = "INPUT_PORT"
+ conn.source_relationship = ""
Review Comment:
probably doesn't matter, but this is usually set to `"undefined"`, not to an
empty string
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
