bobpaulin commented on code in PR #10931:
URL: https://github.com/apache/nifi/pull/10931#discussion_r2843622421
##########
nifi-framework-bundle/nifi-framework/nifi-framework-core/src/main/java/org/apache/nifi/components/connector/StandardConnectorNode.java:
##########
@@ -309,6 +309,11 @@ private void destroyWorkingContext() {
public void abortUpdate(final Throwable cause) {
stateTransition.setCurrentState(ConnectorState.UPDATE_FAILED);
stateTransition.setDesiredState(ConnectorState.UPDATE_FAILED);
+ validationState.set(new ValidationState(ValidationStatus.INVALID,
List.of(new ValidationResult.Builder()
+ .subject("Flow Update Failure")
+ .valid(false)
+ .explanation("The flow could not be updated.")
+ .build())));
Review Comment:
Yeah that sounds reasonable I hadn't considered the drain usecase. Will
work some conditionality in so this only hits when we're in a unrecoverably
invalid state.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
