pvillard31 opened a new pull request, #10937: URL: https://github.com/apache/nifi/pull/10937
# Summary NIFI-15648 - Resolve SECRET property values before fetchAllowableValues and verify in working flow context When a connector calls fetchAllowableValues, the working flow context's ConnectorConfigurationContext may return null for properties with PropertyType.SECRET. This occurs because at the time the working flow context is cloned and setProperties resolves secrets, the backing ParameterProvider may not yet be valid, causing ParameterProviderSecretsManager.getSecretProviders() to return an empty set. The secret resolution silently stores null, and there is no subsequent re-resolution. This does not affect verifyConfigurationStep, which bypasses stored resolved values by accepting explicit propertyValueOverrides from the UI and creating a new context with StringLiteralValue entries. The fix adds resolvePropertyValues() calls in StandardConnectorNode before delegating to the connector's fetchAllowableValues (both overloads) and verify methods. This re-resolves SecretReference entries against the SecretsManager at the point of need, when the ParameterProvider is expected to be valid. This mirrors the existing pattern in start(), which already calls resolvePropertyValues() on the active flow context before starting the connector. # Tracking Please complete the following tracking steps prior to pull request creation. ### Issue Tracking - [ ] [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI) issue created ### Pull Request Tracking - [ ] Pull Request title starts with Apache NiFi Jira issue number, such as `NIFI-00000` - [ ] Pull Request commit message starts with Apache NiFi Jira issue number, as such `NIFI-00000` - [ ] Pull request contains [commits signed](https://docs.github.com/en/authentication/managing-commit-signature-verification/signing-commits) with a registered key indicating `Verified` status ### Pull Request Formatting - [ ] Pull Request based on current revision of the `main` branch - [ ] Pull Request refers to a feature branch with one commit containing changes # Verification Please indicate the verification steps performed prior to pull request creation. ### Build - [ ] Build completed using `./mvnw clean install -P contrib-check` - [ ] JDK 21 - [ ] JDK 25 ### Licensing - [ ] New dependencies are compatible with the [Apache License 2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License Policy](https://www.apache.org/legal/resolved.html) - [ ] New dependencies are documented in applicable `LICENSE` and `NOTICE` files ### Documentation - [ ] Documentation formatting appears as expected in rendered files -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
