pvillard31 opened a new pull request, #10946:
URL: https://github.com/apache/nifi/pull/10946
# Summary
NIFI-15655 - Flaky System Test
FlowSynchronizationIT.testUnnecessaryProcessorsAndConnectionsRemoved
```
[ERROR] Tests run: 14, Failures: 0, Errors: 1, Skipped: 0, Time elapsed:
382.2 s <<< FAILURE! -- in
org.apache.nifi.tests.system.clustering.FlowSynchronizationIT
[ERROR]
org.apache.nifi.tests.system.clustering.FlowSynchronizationIT.testUnnecessaryProcessorsAndConnectionsRemoved
-- Time elapsed: 312.5 s <<< ERROR!
java.util.concurrent.TimeoutException:
testUnnecessaryProcessorsAndConnectionsRemoved() timed out after 5 minutes
at java.base/java.util.ArrayList.forEach(ArrayList.java:1596)
at java.base/java.util.ArrayList.forEach(ArrayList.java:1596)
Suppressed: java.lang.InterruptedException: sleep interrupted
at java.base/java.lang.Thread.sleep0(Native Method)
at java.base/java.lang.Thread.sleep(Thread.java:509)
at
org.apache.nifi.tests.system.NiFiSystemIT.waitFor(NiFiSystemIT.java:420)
at
org.apache.nifi.tests.system.NiFiSystemIT.waitFor(NiFiSystemIT.java:407)
at
org.apache.nifi.tests.system.clustering.FlowSynchronizationIT.testUnnecessaryProcessorsAndConnectionsRemoved(FlowSynchronizationIT.java:718)
```
During the disconnect/reconnect cycle, ZooKeeper leader election can
transiently return an address without a port. Previously, this caused an
`ArrayIndexOutOfBoundsException` — which, while caught by `HeartbeatSendTask`'s
catch (`Throwable`), produced an opaque error. With the fix, both layers now
throw a proper `ProtocolException` with a clear message. The
`ProtocolException` is still caught by the same catch (`Throwable`) handler in
`HeartbeatSendTask.run()`, the heartbeat task continues running, and the next
cycle succeeds once leader election stabilizes. The clearer exception type and
message also make the transient condition far easier to diagnose in logs.
# Tracking
Please complete the following tracking steps prior to pull request creation.
### Issue Tracking
- [ ] [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI) issue
created
### Pull Request Tracking
- [ ] Pull Request title starts with Apache NiFi Jira issue number, such as
`NIFI-00000`
- [ ] Pull Request commit message starts with Apache NiFi Jira issue number,
as such `NIFI-00000`
- [ ] Pull request contains [commits
signed](https://docs.github.com/en/authentication/managing-commit-signature-verification/signing-commits)
with a registered key indicating `Verified` status
### Pull Request Formatting
- [ ] Pull Request based on current revision of the `main` branch
- [ ] Pull Request refers to a feature branch with one commit containing
changes
# Verification
Please indicate the verification steps performed prior to pull request
creation.
### Build
- [ ] Build completed using `./mvnw clean install -P contrib-check`
- [ ] JDK 21
- [ ] JDK 25
### Licensing
- [ ] New dependencies are compatible with the [Apache License
2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License
Policy](https://www.apache.org/legal/resolved.html)
- [ ] New dependencies are documented in applicable `LICENSE` and `NOTICE`
files
### Documentation
- [ ] Documentation formatting appears as expected in rendered files
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
