[
https://issues.apache.org/jira/browse/NIFI-3478?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15866282#comment-15866282
]
ASF GitHub Bot commented on NIFI-3478:
--------------------------------------
Github user joewitt commented on a diff in the pull request:
https://github.com/apache/nifi/pull/1507#discussion_r101101791
--- Diff:
nifi-nar-bundles/nifi-enrich-bundle/nifi-enrich-processors/src/main/java/org/apache/nifi/processors/GeoEnrichIP.java
---
@@ -79,33 +80,37 @@
@WritesAttribute(attribute = "X.geo.postalcode", description = "The
postal code for the country identified"),})
public class GeoEnrichIP extends AbstractProcessor {
- public static final PropertyDescriptor GEO_DATABASE_FILE = new
PropertyDescriptor.Builder()
+ static final PropertyDescriptor GEO_DATABASE_FILE = new
PropertyDescriptor.Builder()
.name("Geo Database File")
+ .displayName("Geo Database File")
.description("Path to Maxmind Geo Enrichment Database File")
.required(true)
.addValidator(StandardValidators.FILE_EXISTS_VALIDATOR)
.build();
- public static final PropertyDescriptor IP_ADDRESS_ATTRIBUTE = new
PropertyDescriptor.Builder()
+ static final PropertyDescriptor IP_ADDRESS_ATTRIBUTE = new
PropertyDescriptor.Builder()
.name("IP Address Attribute")
+ .defaultValue("IP Address Attribute")
--- End diff --
please remove this default value. It should be entered by the user.
> GeoEnrich Processor's 'IP Address Attribute' Should Support Expression
> Language
> --------------------------------------------------------------------------------
>
> Key: NIFI-3478
> URL: https://issues.apache.org/jira/browse/NIFI-3478
> Project: Apache NiFi
> Issue Type: Improvement
> Components: Extensions
> Reporter: Josh Meyer
> Assignee: Josh Meyer
> Priority: Trivial
>
> It would be beneficial if the GeoEnrich processor supported expression
> language. This could be helpful if for some reason a user needs to build the
> attribute name.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
