Github user joewitt commented on a diff in the pull request:

    https://github.com/apache/nifi/pull/1507#discussion_r101101791
  
    --- Diff: 
nifi-nar-bundles/nifi-enrich-bundle/nifi-enrich-processors/src/main/java/org/apache/nifi/processors/GeoEnrichIP.java
 ---
    @@ -79,33 +80,37 @@
         @WritesAttribute(attribute = "X.geo.postalcode", description = "The 
postal code for the country identified"),})
     public class GeoEnrichIP extends AbstractProcessor {
     
    -    public static final PropertyDescriptor GEO_DATABASE_FILE = new 
PropertyDescriptor.Builder()
    +    static final PropertyDescriptor GEO_DATABASE_FILE = new 
PropertyDescriptor.Builder()
                 .name("Geo Database File")
    +            .displayName("Geo Database File")
                 .description("Path to Maxmind Geo Enrichment Database File")
                 .required(true)
                 .addValidator(StandardValidators.FILE_EXISTS_VALIDATOR)
                 .build();
     
    -    public static final PropertyDescriptor IP_ADDRESS_ATTRIBUTE = new 
PropertyDescriptor.Builder()
    +    static final PropertyDescriptor IP_ADDRESS_ATTRIBUTE = new 
PropertyDescriptor.Builder()
                 .name("IP Address Attribute")
    +            .defaultValue("IP Address Attribute")
    --- End diff --
    
    please remove this default value.  It should be entered by the user.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to